Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): add specific commands for each component #4715

Merged
merged 4 commits into from
Oct 24, 2018

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Oct 19, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Oct 19, 2018
@ghost ghost added the needs review label Oct 19, 2018
@Domainv Domainv added the WIP label Oct 19, 2018
@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #4715 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4715   +/-   ##
============================================
  Coverage        74.31%   74.31%           
============================================
  Files              202      202           
  Lines             7102     7102           
  Branches          1447     1447           
============================================
  Hits              5278     5278           
  Misses            1427     1427           
  Partials           397      397

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5de6dd...4bc5030. Read the comment docs.

@Domainv Domainv force-pushed the feat-schematics-ng-add-specific-module branch 2 times, most recently from b6d315d to a0efcb7 Compare October 22, 2018 08:18
@Domainv Domainv force-pushed the feat-schematics-ng-add-specific-module branch 3 times, most recently from 52b25ed to 7f04ee0 Compare October 23, 2018 13:13
@Domainv Domainv force-pushed the feat-schematics-ng-add-specific-module branch from 7f04ee0 to 3f8df6a Compare October 23, 2018 13:22
@Domainv Domainv force-pushed the feat-schematics-ng-add-specific-module branch from 3f8df6a to ef36304 Compare October 23, 2018 13:30
@ludmilanesvitiy
Copy link
Contributor

screenshot from 2018-10-24 12-08-18
After adding specific component or ngx-bs at all, there is a lot of warnings in console. Will be good to avoid it. Other functionality with adding components works well.

@Domainv
Copy link
Contributor Author

Domainv commented Oct 24, 2018

screen shot 2018-10-24 at 7 00 39 pm

@valorkin valorkin merged commit 26cc974 into development Oct 24, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-schematics-ng-add-specific-module branch October 24, 2018 18:47
@ghost ghost removed the ready for merge label Oct 24, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
…tware#4715)

* fix(merge): merge with development

* feat(schematics): update test, clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants