feat(datepicker): Slovak locale added to chronos #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## development #4391 +/- ##
===============================================
- Coverage 71.4% 71.39% -0.01%
===============================================
Files 258 259 +1
Lines 8329 8377 +48
Branches 1539 1561 +22
===============================================
+ Hits 5947 5981 +34
- Misses 1979 1989 +10
- Partials 403 407 +4
Continue to review full report at Codecov.
|
valorkin
approved these changes
Jun 25, 2018
|
When will be this published to NPM (as 3.0.2)? We would really need this. Thank you |
|
We are upgrading our build process.... and stuck a bit ;( but we can see a light :) |
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
Slovak language
This request introduces a new language to localize the datepicker component into Slovak.
Why is it so complicated to add a new language to this project - basically the same approach as in the moment.js library? Is this a design issue that does not allow the reuse of language specification from moment.js as primary source, even if no specific language settings exists in chronos directory? This seems to me to be an unnecessary task, creating almost 100% identical files like in moment.