Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): Galician locale #4246

Merged
merged 3 commits into from
Apr 25, 2018

Conversation

PorkoBravo
Copy link
Contributor

Added Galician locale

PR Checklist

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #4246 into development will decrease coverage by 0.02%.
The diff coverage is 58.82%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4246      +/-   ##
===============================================
- Coverage        72.26%   72.24%   -0.03%     
===============================================
  Files              255      256       +1     
  Lines             8276     8293      +17     
  Branches          1582     1589       +7     
===============================================
+ Hits              5981     5991      +10     
- Misses            1872     1873       +1     
- Partials           423      429       +6
Impacted Files Coverage Δ
src/locale.ts 100% <100%> (ø) ⬆️
src/chronos/i18n/gl.ts 56.25% <56.25%> (ø)
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92a488...9faf58d. Read the comment docs.

@ghost ghost added the needs review label Apr 25, 2018
roLocale import and const is added after it was deleted by error
@valorkin
Copy link
Member

@QuinoBravo thanks for your help!

sorry for a delay, I were busy organizing https://ngtalks.io/

@valorkin valorkin merged commit 08e3f56 into valor-software:development Apr 25, 2018
@ghost ghost removed the needs review label Apr 25, 2018
@PorkoBravo PorkoBravo deleted the galician-locale branch April 25, 2018 14:24
@PorkoBravo
Copy link
Contributor Author

@valorkin thanks to you and the entire team!

sorry for a delay, I were busy organizing https://ngtalks.io/

Don't worry, it is for a good cause 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants