Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): toggle carousel-indicators via property #3319

Merged

Conversation

fhuschle
Copy link
Contributor

Hi,

toggle the carousel-indicators via property (default == true).
Closes #1021

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

Merging #3319 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3319      +/-   ##
===============================================
+ Coverage        72.33%   72.34%   +<.01%     
===============================================
  Files              249      249              
  Lines             8054     8056       +2     
  Branches          1528     1528              
===============================================
+ Hits              5826     5828       +2     
  Misses            1806     1806              
  Partials           422      422
Impacted Files Coverage Δ
src/carousel/carousel.config.ts 100% <100%> (ø) ⬆️
src/carousel/carousel.component.ts 92.37% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a54df...04dfcf4. Read the comment docs.

@ghost ghost assigned IlyaSurmay Dec 20, 2017
@ghost ghost added the in progress label Dec 20, 2017
@valorkin
Copy link
Member

valorkin commented Jan 5, 2018

@EvilAlexei please add this option to carousel roadmap plan
@valorkin done

@YevheniiaMazur
Copy link

Added new feature to Carousel Dynamic demo. All changes were tested, looks good. Need dev review

@valorkin valorkin merged commit 4164937 into valor-software:development Jan 18, 2018
@valorkin
Copy link
Member

Thanks for your time and help ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants