Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using deprecated ngOutletContext, Angular 5.x will fail to build #2658

Closed
MrBlaise opened this issue Sep 15, 2017 · 6 comments
Closed

Using deprecated ngOutletContext, Angular 5.x will fail to build #2658

MrBlaise opened this issue Sep 15, 2017 · 6 comments

Comments

@MrBlaise
Copy link
Contributor

The ngOutletContext is deprecated in Angular 4 and will be removed in Angular 5. Please use
ngTemplateOutletContext

https://github.com/angular/angular/blob/master/CHANGELOG.md#deprecated-code

It is used here for example: https://github.com/valor-software/ngx-bootstrap/blob/31c5f62a48560d4372f0043241829a27e5f3deb6/src/sortable/sortable.component.ts (line 42)

Other files I found with ngOutletContext:

  • src/typeahead/typeahead-container.component.html
  • src/rating/rating.component.html
  • src/sortable/sortable.component.ts
@MrBlaise
Copy link
Contributor Author

Created a PR: #2659

@valorkin
Copy link
Member

Thanks for, at the moment we are working on dropping support of ng 2, and moving to support ng v4 and v5
So PR is just in time :)

@Anoop-Goudar
Copy link

By replacing ngOutletContext to ngTemplateOutletContext in all files, it worked for me.

@MrBlaise
Copy link
Contributor Author

MrBlaise commented Nov 8, 2017

@Anoop-Goudar That is exactly what this PR did, and it is already merged, so use the latest beta version.

@Anoop-Goudar
Copy link

@MrBlaise Thanks, I updated the package ngx-bootstrap to 2.0.0-beta.8

@its-Aman
Copy link

I was using ion2-calendar. It was using ngOutletContext. Replacing it with ngTemplateOutletContext worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants