Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carousel setInterval by running it outside of Angular zone. #2388

Merged
merged 4 commits into from
Aug 21, 2017

Conversation

aecz
Copy link
Contributor

@aecz aecz commented Aug 9, 2017

By doing so, Angular zone gets stable and Universal stops waiting indefinitely.
Also ApplicationRef.isStable works now as expected.

@codecov
Copy link

codecov bot commented Aug 14, 2017

Codecov Report

Merging #2388 into development will increase coverage by 10.96%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development    #2388       +/-   ##
================================================
+ Coverage        75.92%   86.89%   +10.96%     
================================================
  Files              121       96       -25     
  Lines             3614     2731      -883     
  Branches           475      366      -109     
================================================
- Hits              2744     2373      -371     
+ Misses             745      233      -512     
  Partials           125      125
Impacted Files Coverage Δ
src/carousel/carousel.component.ts 91.89% <100%> (+0.22%) ⬆️
src/collapse/collapse.module.ts 85.71% <0%> (-14.29%) ⬇️
src/buttons/buttons.module.ts 87.5% <0%> (-12.5%) ⬇️
src/modal/modal-options.class.ts
src/buttons/index.ts
src/pagination/index.ts
src/rating/index.ts
src/datepicker/yearpicker.component.ts
src/accordion/index.ts
src/datepicker/datepicker.config.ts
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd456b...cd1ec6b. Read the comment docs.

@valorkin
Copy link
Member

awesome! Thanks

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit da073df into valor-software:development Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants