From 7ce57e9463d6124fa7f0c1444de4a9c3c273ca25 Mon Sep 17 00:00:00 2001 From: Yury-Fridlyand Date: Wed, 9 Oct 2024 13:04:44 -0700 Subject: [PATCH 1/5] Run modules CI on demand. Signed-off-by: Yury-Fridlyand --- .github/workflows/java.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml index d5d0697abb..d87c9a0453 100644 --- a/.github/workflows/java.yml +++ b/.github/workflows/java.yml @@ -197,9 +197,8 @@ jobs: name: lint java rust test-modules: - if: github.event.pull_request.head.repo.owner.login == 'valkey-io' - environment: AWS_ACTIONS - name: Running Module Tests + if: github.repository_owner == 'valkey-io' + name: Modules Tests runs-on: [self-hosted, linux, ARM64] timeout-minutes: 15 steps: From 4264e0d6847ffa8f0de8b7594b68a2c8617ccdd1 Mon Sep 17 00:00:00 2001 From: Yury-Fridlyand Date: Wed, 9 Oct 2024 13:29:00 -0700 Subject: [PATCH 2/5] Run modules CI on demand. Signed-off-by: Yury-Fridlyand --- .github/workflows/java.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml index d87c9a0453..27db2691c5 100644 --- a/.github/workflows/java.yml +++ b/.github/workflows/java.yml @@ -197,7 +197,7 @@ jobs: name: lint java rust test-modules: - if: github.repository_owner == 'valkey-io' + if: github.repository_owner == 'valkey-io' && secrets.MEMDB_MODULES_ENDPOINT != '' name: Modules Tests runs-on: [self-hosted, linux, ARM64] timeout-minutes: 15 From 7c6fb015e8f25ae2acbe352b87fc239f62ee3ad0 Mon Sep 17 00:00:00 2001 From: Yury-Fridlyand Date: Wed, 9 Oct 2024 13:33:09 -0700 Subject: [PATCH 3/5] Run modules CI on demand. Signed-off-by: Yury-Fridlyand --- .github/workflows/java.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml index 27db2691c5..d36d758774 100644 --- a/.github/workflows/java.yml +++ b/.github/workflows/java.yml @@ -197,7 +197,7 @@ jobs: name: lint java rust test-modules: - if: github.repository_owner == 'valkey-io' && secrets.MEMDB_MODULES_ENDPOINT != '' + if: (github.repository_owner == 'valkey-io' && github.event_name == 'workflow_dispatch') || github.event.pull_request.head.repo.owner.login == 'valkey-io' name: Modules Tests runs-on: [self-hosted, linux, ARM64] timeout-minutes: 15 From 6ab9b6449b4d6124a8fe32196e7f49004009f256 Mon Sep 17 00:00:00 2001 From: Yury-Fridlyand Date: Wed, 9 Oct 2024 13:49:16 -0700 Subject: [PATCH 4/5] changelog Signed-off-by: Yury-Fridlyand --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 72d205fefb..951d0cc2a4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ #### Operational Enhancements +* Java: Add modules CI ([#2388](https://github.com/valkey-io/valkey-glide/pull/2388), [#2404](https://github.com/valkey-io/valkey-glide/pull/2404), [#2416](https://github.com/valkey-io/valkey-glide/pull/2416)) + ## 1.1.0 (2024-09-24) #### Changes From b6866e4f93654f2a113dde37db7bb924d70ccf98 Mon Sep 17 00:00:00 2001 From: Yury-Fridlyand Date: Thu, 10 Oct 2024 10:19:48 -0700 Subject: [PATCH 5/5] Address PR review. Signed-off-by: Yury-Fridlyand --- .github/workflows/java.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml index d36d758774..ca626224f4 100644 --- a/.github/workflows/java.yml +++ b/.github/workflows/java.yml @@ -198,6 +198,7 @@ jobs: test-modules: if: (github.repository_owner == 'valkey-io' && github.event_name == 'workflow_dispatch') || github.event.pull_request.head.repo.owner.login == 'valkey-io' + environment: AWS_ACTIONS name: Modules Tests runs-on: [self-hosted, linux, ARM64] timeout-minutes: 15