Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Infinity on float and double #33

Open
GooRiOn opened this issue Oct 8, 2017 · 3 comments
Open

Support for Infinity on float and double #33

GooRiOn opened this issue Oct 8, 2017 · 3 comments
Labels
change request enhancement up-for-grabs

Comments

@GooRiOn
Copy link
Member

GooRiOn commented Oct 8, 2017

We should consider validation for Infinity in double and float. It might be tricky and honestly I don't know how how rules are implemented in C#. It's not super important imho.
@arekbal
Copy link
Contributor

arekbal commented Oct 8, 2017 •
edited
Loading

It is only important with our epsilon calculations and subtraction(#32). I guess we cannot do 3.f - Single.PositiveInfinity or a reverse of this operation. Algorithm for this should just check values before doing subtraction. Oh... and Math.Abs(Single.NegativeInfinity) does what? returns positive? :D

@GooRiOn GooRiOn self-assigned this Oct 12, 2017
@GooRiOn GooRiOn modified the milestone: 0.1.0 Oct 12, 2017
@GooRiOn GooRiOn removed their assignment Nov 29, 2017
@dbarwikowski
Copy link
Member

@arekbal returns 'Application encountered unexpected operation and needs to restart your operating system'

@arekbal
Copy link
Contributor

arekbal commented Apr 3, 2018

returns Positive :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change request enhancement up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arekbal @GooRiOn @dbarwikowski