-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified symbolRegex in isStrongPassword to include '\' #2278
Modified symbolRegex in isStrongPassword to include '\' #2278
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2454 2454
Branches 619 619
=======================================
Hits 2453 2453
Partials 1 1
☔ View full report in Codecov by Sentry. |
Thanks for the PR! Don't forget to add additional tests before we can review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are working and changes are legit.
isStrongPassword - Bug fix
I modified the special character regex a little bit to add validation for '\' character. I worked on this based on an issue in the repository
Checklist