Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isLength): added process to subtract Presentation Sequences characters #1967

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

ikkyu-3
Copy link
Contributor

@ikkyu-3 ikkyu-3 commented May 15, 2022

#1941

  • Added process to subtract presentation sequence characters from total characters
  • Edited test

https://unicode.org/reports/tr51/#Emoji_Variation_Sequences

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #1967 (95345ae) into master (cfcf911) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1967   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2098    +1     
  Branches       473       474    +1     
=========================================
+ Hits          2097      2098    +1     
Impacted Files Coverage Δ
src/lib/isLength.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...95345ae. Read the comment docs.

@rubiin rubiin merged commit 49c3abe into validatorjs:master Jul 18, 2022
@rubiin
Copy link
Member

rubiin commented Jul 18, 2022

Thankyou for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants