feat(isBase32): Add option for Crockford's base 32 alternative #1888
Conversation
…to isBase32 method
Codecov Report
@@ Coverage Diff @@
## master #1888 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2072 2078 +6
Branches 472 473 +1
=========================================
+ Hits 2072 2078 +6
Continue to review full report at Codecov.
|
test/validators.js
Outdated
|
|
||
| test({ | ||
| validator: 'isBase32', | ||
| args: [{ crockford: true }], | ||
| valid: [ | ||
| '91JPRV3F41BPYWKCCGGG', | ||
| '60', | ||
| '64', | ||
| 'B5QQA833C5Q20S3F41MQ8', | ||
| ], | ||
| invalid: [ | ||
| '91JPRV3F41BUPYWKCCGGG', | ||
| 'B5QQA833C5Q20S3F41MQ8L', | ||
| '60I', | ||
| 'B5QQA833OULIC5Q20S3F41MQ8', | ||
| ], | ||
| }); |
There was a problem hiding this comment.
I would suggest you move this test out to its own it() statement so it is more clear precisely what is being tested. At least many other tests are split up like this. See 'should validate JSON' and 'should validate JSON with primitives'.
Examples to the contrary are found as well ('should validate ISSNs' has everything in one it() statement), so I suppose a clarification of the convention here would be nice, but that's a bigger topic.
|
I move the test out. 🙂 |
Co-authored-by: Brage <[email protected]>
|
I think the title should be feat(isBase32): Add option for Crockford's base 32 alternative |
BigOsvaap
changed the title
|
I updated the name of the PR :) |
This PR adds feature requested on issue #1857
Checklist