-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(isSlug & rtrim): regex no longer exposed to ReDOS attacks #1603
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1798 +2
=========================================
+ Hits 1796 1798 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 thank you for spotting and fixing the ReDOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
This should be merged after #1602
Regexes are updated in order not to change their behaviour, but only their logic.
Fixes #1596 and fixes #1599
Checklist