Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMobilePhone locale should default to 'any' #854

Closed
towc opened this issue Jun 20, 2018 · 3 comments
Closed

isMobilePhone locale should default to 'any' #854

towc opened this issue Jun 20, 2018 · 3 comments

Comments

@towc
Copy link
Contributor

towc commented Jun 20, 2018

currently, if you don't pass a second argument, it fails with invalid locale 'undefined', which means you have to look at the docs/source code to figure out what to do, while it's very likely you just want any locale.

setting the default locale to any shouldn't break any code, because if there's no second argument, it just fails.

Agree or disagree?

@chriso
Copy link
Collaborator

chriso commented Jul 31, 2018

Agreed. Happy to accept a PR with the change.

@towc
Copy link
Contributor Author

towc commented Jul 31, 2018

1 PR and a soda coming up

@chriso
Copy link
Collaborator

chriso commented Jul 31, 2018

Fixed by #874. This will go out in the next release.

@chriso chriso closed this as completed Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants