Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isFQDN is not checking parts length #787

Closed
jfhs opened this issue Feb 5, 2018 · 0 comments
Closed

isFQDN is not checking parts length #787

jfhs opened this issue Feb 5, 2018 · 0 comments

Comments

@jfhs
Copy link

jfhs commented Feb 5, 2018 •
edited
Loading

Per RFC 1034 each part in domain should be at most 63 octets long. This is not being checked by isFQDN and all functions dependent on it (i.e. isEmail):

validator.isFQDN('a'.repeat(100) + '.com'); // returns true
@chriso chriso closed this as completed in bb3e542 May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfhs