Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale-aware validation in isFloat() #547

Closed
shakvaal opened this issue Jun 23, 2016 · 2 comments · Fixed by #721
Closed

Locale-aware validation in isFloat() #547

shakvaal opened this issue Jun 23, 2016 · 2 comments · Fixed by #721
Labels
🙋‍♂️feature-request

Comments

@shakvaal
Copy link

validator.isFloat('4,44') === false

How do I deal with that? Is there any localization switch for such cases?
@chriso
Copy link
Collaborator

chriso commented Jun 23, 2016

This isn't currently supported. I'd accept a PR to introduce a locale, e.g. how isAlpha works.

This was referenced Jun 24, 2016
Closed
Closed
@chriso chriso changed the title How do I validate floats with commas? Locale-aware validation in isFloat() Jul 15, 2016
@chriso
Copy link
Collaborator

chriso commented Sep 10, 2016

Happy to accept a PR 😄

@linkinmedo linkinmedo mentioned this issue Sep 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋‍♂️feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add local and decimal options to isDecimal & add local to isFloat linkinmedo/validator.js
2 participants
@chriso @shakvaal