Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: isEmail returns true for "amazon-[%lowletter(20,25)]_"@xyz.com even when you pass blacklisted_chars and other options #2508

Closed
titanism opened this issue Dec 12, 2024 · 4 comments
Closed

Bug: isEmail returns true for "amazon-[%lowletter(20,25)]_"@xyz.com even when you pass blacklisted_chars and other options #2508

titanism opened this issue Dec 12, 2024 · 4 comments
Labels
🐛 bug

Comments

@titanism
Copy link

Major bug as defined in title. This is a core bug.
@titanism titanism mentioned this issue Dec 12, 2024
Open
@titanism
Copy link
Author 

> require('validator').isEmail('"amazon-[%lowletter(20,25)]_"@xyz.com')
true

@titanism
Copy link
Author

This was fixed in 283a6a5#diff-05af3209e43990aab23ea6e75131e4fcc77bba0a3253b02d77f648c3849ad0c9R169 and 3448e9d

@titanism titanism mentioned this issue Dec 12, 2024
Open
@titanism
Copy link
Author

This is still an issue.

@titanism titanism reopened this Dec 12, 2024
@titanism
Copy link
Author

Nevermind, we need to pass blacklisted_chars option:

> require('@forwardemail/validator').isEmail('"amazon-[%lowletter(20,25)]_"@xyz.com')
true
> require('@forwardemail/validator').isEmail('"amazon-[%lowletter(20,25)]_"@xyz.com', { blacklisted_chars: '"' })
false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@titanism