Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The isDate function throws an error when passed a string parameter. #2452

Closed
yikouning opened this issue Sep 14, 2024 · 5 comments
Closed

The isDate function throws an error when passed a string parameter. #2452

yikouning opened this issue Sep 14, 2024 · 5 comments
Labels

Comments

@yikouning
Copy link

Snipaste_2024-09-14_16-28-16 Snipaste_2024-09-14_16-34-43

When using the isDate function to check if an unknown string is in date format, it directly throws an error, as shown in the screenshot. The input I passed was “abcd”. Is using the string’s length for validation not rigorous enough? The Validator.js version is 13.12.0.

@pano9000
Copy link
Contributor

most likely this is the same issue as #2427, which got fixed with #2443 - unfortunately the fix has not been packaged into a new version yet...
will confirm later this evening, if that really is the case, but in any case:
@profnandaa any chance of getting a new release anytime soon? :-)

@yikouning
Copy link
Author

这很可能与#2427是同一问题,已通过#2443修复-不幸的是修复尚未备份到新版本中... 将在今晚确认,如果确实如此,但无论如何: @profnandaa近期有机会发布新版本吗?:-)
Thank you so much for addressing the issue! I really appreciate your time and effort in fixing it. I’ll give it a try and let you know if I encounter any further problems. Thanks again for your help!

@pano9000
Copy link
Contributor

just confirmed, with the latest commit from main, there is no error throw - if I use an earlier commit than the ones from #2443 -> error is thrown.

So marking this as fixed by #2443

@Melvinvmegen
Copy link

Melvinvmegen commented Oct 21, 2024

@pano9000 Can we get a release for this or should i npm install the specific commit?

@rubiin
Copy link
Member

rubiin commented Oct 21, 2024

@profnandaa lets schedule a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants