-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isHSLA() #1245
Comments
would this not just be a redirect to the |
@AubreyHewes based on the feedback received on #1159, @GuiSchafer mentioned the following when I asked on the same
May be @profnandaa and @GuiSchafer could add something on the same. |
In my opinion, semantically would be better to have this two separated. They are, indeed, correlated, but I wouldn't expect to receive "true" as an return value from a isHSL function when passing a hsla string. Futhermore, I think mixing this two would expand, in a bad way, the responsability of the function. What do you guys think? |
I would love to pick this up, can I take it up? |
@lytes20 please raise a PR. |
Upon refining PR #1159, I agree with @AubreyHewes to simply redirect to the |
#1159 will close this issue @profnandaa. |
Add
isHSLA()
.Refer to the following issue (Similar but not the same) #1156.
Also, refer to the following PR raised #1156
Finally, check on the docs of MDN and W3Resource
The text was updated successfully, but these errors were encountered: