Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: isBase32 #1013

Closed
gelatosamantha opened this issue Apr 10, 2019 · 3 comments
Closed

Feature Request: isBase32 #1013

gelatosamantha opened this issue Apr 10, 2019 · 3 comments
Labels
🙋‍♂️feature-request pr-raised

Comments

@gelatosamantha
Copy link

As Google Authenticator requires keys to be base32 encoded, base32 format checking should be widely used. Can you also add this in ?
@profnandaa
Copy link
Member

PR is welcome! 👍

@razananisathar
Copy link
Contributor

@profnandaa I have added isBase32 validator and PR created. Please review. Thanks.

@profnandaa profnandaa mentioned this issue May 4, 2019
Merged
@chriso
Copy link
Collaborator

chriso commented May 23, 2019

Fixed by #1023.

@chriso chriso closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋‍♂️feature-request pr-raised
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@profnandaa @chriso @gelatosamantha @razananisathar