Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use patch helpers; batch validation rule result updates #39

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

TylerGillson
Copy link
Member

No description provided.

@TylerGillson TylerGillson requested a review from a team March 12, 2024 19:34
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #39 (153b1fe) into main (dbb1611) will decrease coverage by 1.27%.
The diff coverage is 51.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   62.85%   61.58%   -1.27%     
==========================================
  Files           2        2              
  Lines         140      151      +11     
==========================================
+ Hits           88       93       +5     
- Misses         49       52       +3     
- Partials        3        6       +3     
Files Coverage Δ
internal/validators/maas_validator.go 39.13% <0.00%> (+0.55%) ⬆️
internal/controller/maasvalidator_controller.go 80.48% <66.66%> (-6.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb1611...153b1fe. Read the comment docs.

@TylerGillson TylerGillson merged commit 9e3be19 into main Mar 12, 2024
5 of 8 checks passed
@TylerGillson TylerGillson deleted the refactor/patch-helper branch March 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants