chore: assert that PluginSpec is implemented #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
TylerGillson
approved these changes
Aug 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 74.22% 74.22%
=======================================
Files 9 9
Lines 357 357
=======================================
Hits 265 265
Misses 76 76
Partials 16 16
Continue to review full report in Codecov by Sentry.
|
mattwelke
force-pushed
the
feat/enforce-plugin-spec
branch
from
c041442
to
46642b0
Compare
mattwelke
pushed a commit
that referenced
this pull request
Aug 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.10](v0.0.9...v0.0.10) (2024-08-23) ### Bug Fixes * embedding structs related to `validationrule.Interface` ([#135](#135)) ([166aece](166aece)) ### Other * assert that PluginSpec is implemented ([#133](#133)) ([e280094](e280094)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahmad-ibra
added a commit
that referenced
this pull request
Aug 23, 2024
## Issue Related to validator-labs/validatorctl#178 ## Description Asserts that the PluginSpec interface is implemented
mattwelke
pushed a commit
that referenced
this pull request
Aug 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.8](v0.0.7...v0.0.8) (2024-08-23) ### Bug Fixes * embedding structs related to `validationrule.Interface` ([#135](#135)) ([4ebf38a](4ebf38a)) ### Other * assert that PluginSpec is implemented ([#133](#133)) ([cf2c23f](cf2c23f)) * satisfy ValidationRule ([#121](#121)) ([5894f51](5894f51)) ### Dependency Updates * **deps:** update module github.com/canonical/gomaasclient to v0.7.0 ([4942f99](4942f99)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.0 ([951e094](951e094)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.1 ([cab9803](cab9803)) * **deps:** update module github.com/validator-labs/validator to v0.1.2 ([df63d44](df63d44)) * **deps:** update module github.com/validator-labs/validator to v0.1.5 ([#123](#123)) ([a856370](a856370)) * **deps:** update module github.com/validator-labs/validator to v0.1.6 ([5dbc31f](5dbc31f)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.0 ([#124](#124)) ([e903cc7](e903cc7)) ### Refactoring * make each rule implement `validationrule.Interface` ([#130](#130)) ([381e3ab](381e3ab)) * make remaining rules implement rule interface ([#131](#131)) ([ed0bc5b](ed0bc5b)) * support direct rule evaluation ([#118](#118)) ([e4d873d](e4d873d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
TylerGillson
added a commit
that referenced
this pull request
Aug 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.8](v0.0.7...v0.0.8) (2024-08-23) ### Bug Fixes * embedding structs related to `validationrule.Interface` ([#135](#135)) ([4ebf38a](4ebf38a)) ### Other * assert that PluginSpec is implemented ([#133](#133)) ([cf2c23f](cf2c23f)) * satisfy ValidationRule ([#121](#121)) ([5894f51](5894f51)) ### Dependency Updates * **deps:** update module github.com/canonical/gomaasclient to v0.7.0 ([4942f99](4942f99)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.0 ([951e094](951e094)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.1 ([cab9803](cab9803)) * **deps:** update module github.com/validator-labs/validator to v0.1.2 ([df63d44](df63d44)) * **deps:** update module github.com/validator-labs/validator to v0.1.5 ([#123](#123)) ([a856370](a856370)) * **deps:** update module github.com/validator-labs/validator to v0.1.6 ([5dbc31f](5dbc31f)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.0 ([#124](#124)) ([e903cc7](e903cc7)) ### Refactoring * make each rule implement `validationrule.Interface` ([#130](#130)) ([381e3ab](381e3ab)) * make remaining rules implement rule interface ([#131](#131)) ([ed0bc5b](ed0bc5b)) * support direct rule evaluation ([#118](#118)) ([e4d873d](e4d873d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mattwelke
pushed a commit
that referenced
this pull request
Aug 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.11](v0.0.11...v0.0.11) (2024-08-24) ### Other * add retract directive for versions v0.0.8-v0.0.10, release 0.0.11 ([#147](#147)) ([27e1988](27e1988)) * assert that PluginSpec is implemented ([#133](#133)) ([cf2c23f](cf2c23f)) * manually set version to 0.0.11 for release-please ([#145](#145)) ([f26f1fa](f26f1fa)) * release 0.0.11 ([#149](#149)) ([297bb73](297bb73)) ### Dependency Updates * **deps**: update module github.com/validator-labs/validator to v0.1.8 * **deps:** update module github.com/canonical/gomaasclient to v0.7.0 ([4942f99](4942f99)) * **deps:** update module github.com/validator-labs/validator to v0.1.2 ([df63d44](df63d44)) * **deps:** update module github.com/validator-labs/validator to v0.1.5 ([#123](#123)) ([a856370](a856370)) * **deps:** update module github.com/validator-labs/validator to v0.1.6 ([5dbc31f](5dbc31f)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.0 ([#124](#124)) ([e903cc7](e903cc7)) ### Refactoring * make each rule implement `validationrule.Interface` * initial PR - make each rule implement `validationrule.Interface` ([#130](#130)) ([381e3ab](381e3ab)) * bug fix 1 - embedding structs related to `validationrule.Interface` ([#135](#135)) ([4ebf38a](4ebf38a)) * bug fix 2 - YAML rendering of structs embedded in rules ([#143](#143)) ([c7ae66d](c7ae66d)) * make remaining rules implement rule interface ([#131](#131)) ([ed0bc5b](ed0bc5b)) * support direct rule evaluation ([#118](#118)) ([e4d873d](e4d873d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to validator-labs/validatorctl#178
Description
Asserts that the PluginSpec interface is implemented