internal [202311][IM] Remove the PMON and XCVRD delay on system boot #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vadymhlushko-mlnx <[email protected]>
stepanblyschak
approved these changes
Mar 6, 2024
keboliu
reviewed
Mar 7, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "skip_ledd": true, | |||
| "skip_fancontrol": true, | |||
| "delay_xcvrd": true, | |||
| "delay_xcvrd": false, | |||
There was a problem hiding this comment.
do we need to specify this flag explicitly as 'false' or we can just remove it?
There was a problem hiding this comment.
I'm not sure about removing this, because for some systems which are not going to participate in the fastboot it could be useful, but on the other hand leaving the delay_xcvrd: true going to increase an interface link up time up to 3 min
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To support the
fastbootfeature alongsideindependent module mgmtfeature.Because if the
independent modulefeature is enabled we need theXCVRDto start as soon as possible to identify if the port isSWorFWcontrolled and bring the port to the UP state.Work item tracking
How I did it
Remove the delays for the
PMONdocker andXCVRDdaemon on the SONiC image start.How to verify it
Run the sonic-mgmt/tests/platform_tests/test_advanced_reboot.py - test_fast_reboot
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)