Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm test for testing cert-manager-webhook-hetzner is working well #61

Open
mjtrangoni opened this issue Jan 21, 2024 · 2 comments
Open

Comments

@mjtrangoni
Copy link
Contributor

Hi @vadimkim,

After fixing #60, we should add a simple Helm Chart test. See here.

This way we can assure that the webhook is always 100% working.

  1. It should be default disabled, so that this does not fail on users first installation.
  2. We would need some test hetzner credentials available on this repository, for adding it to the CI
@vadimkim
Copy link
Owner

Thanks. Will read first. After merging #60 I can see that version is automatically incremented to 1.3.1, but tag shows 1.3.0.

@mjtrangoni
Copy link
Contributor Author

@vadimkim I had to create a new version for this CI configuration, otherwise the helm test would fail. Note that app and helm are 2 separated things.

Anyways, you can still update both versions at the same time next time, ie. 1.3.2 or something like that.

The application version will be triggered by the git tag, but the helm package will be triggered by the Helm version in the Chart.yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants