-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full SVG support #5
Comments
Thanks for bringing this up! The problem is Not sure right now how to work around this. |
Until there's a solution, |
Added more tags using |
A solution would to have const el = domify(<svg><iframe></iframe></svg>); where |
I don't think this can be further resolved and probably it's fine. Since The only way to support this would be by changing the babel transform to something that can be parsed at once, like JSX-IR, but really at that point it's best to just go with #7 (comment) React either ignores this issue or is able to correct the NS before actually generating the dom because it has total control over it. |
The list of SVG tags is incomplete, by looking at this one: https://github.com/wooorm/svg-tag-names/blob/master/index.json
In there you can also see regular HTML tag names so it's not as easy as requiring that module.
This uncovers an issue: all the tags in
<svg><iframe></iframe></svg>
should be created with the SVG namespace, that's what the browser does:The only way to do that is to also look for
<svg>
and<foreignElement>
into the parents.The text was updated successfully, but these errors were encountered: