Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vanuatu holidays #1298

Closed
arkid15r opened this issue Jun 9, 2023 · 5 comments
Closed

Add Vanuatu holidays #1298

arkid15r opened this issue Jun 9, 2023 · 5 comments
Assignees

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Jun 9, 2023

@Strategos1
Copy link
Contributor

Strategos1 commented Aug 9, 2023

Issue with make check and make pre-commit

Hi.
I want to contribute to the module because it helped me, so I want to return the favour and contribute with Adding Vanuatu.

I made two files vanuatu.py, test_vanuatu.py. I modified registry.py, init.py and README.srt

I created a new environment and started with $ make setup I ran into a problem with makefile errors

Screenshot 2023-08-09 125407

I tried to $ make check. The same error

It passed $ make test, even $ pytest -s tests/countries/test_vanuatu.py

And on $ make pre-commit, it failed rstcheck

Screenshot 2023-08-09 130127

Could someone please help me?

@arkid15r
Copy link
Collaborator Author

arkid15r commented Aug 9, 2023

Hi @Strategos1
thank you for making Vanuatu holidays support possible!

I guess it would be easier to help you if you exported your code (I understand it's WIP). Try git commit / git push with --no-verify flag.

For the next troubleshooting step I'd run scripts/l10n/generate_po_files.py

@KJhellico
Copy link
Collaborator

@Strategos1,
Seems it's babel problem. As advised here, try to run:

TZ=UTC make setup

I just tried this on gitpod.io and there are no errors. Same for other make commands.

@arkid15r
Copy link
Collaborator Author

Accepted and merged, thank you!

@Strategos1
Copy link
Contributor

No I thank you for all your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants