Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guyana holidays #1196

Open
arkid15r opened this issue May 15, 2023 · 3 comments
Open

Add Guyana holidays #1196

arkid15r opened this issue May 15, 2023 · 3 comments

Comments

@arkid15r
Copy link
Collaborator

Links:

@bors-ltd
Copy link
Contributor

Looks like before we integrate Guyana, we'll have to fix French Guiana using their code GY, instead of the expected GF.

I'm willing to contribute, but I guess it's not just a matter of search and replace. We'll have to go through a deprecation period.

The PR #1063 is fixing this, but it seems stalled.

@arkid15r
Copy link
Collaborator Author

I think you can just add a deprecation warning and make GF available. We don't need to wait for GY removal from FR holidays as it won't clash with the supported ISO-3166 entities.

The PR #1063 is fixing this, but it seems stalled.

Oh yeah, that's an old one. We didn't have a good understanding of a direction for holidays at that time yet. I think we can close that one.

@KJhellico any comments/suggestions?

@KJhellico
Copy link
Collaborator

Yes, I think we can postpone the addition of overseas territories, focusing on the countries from UN list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants