Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkpoints #167

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add Checkpoints #167

merged 1 commit into from
Nov 21, 2024

Conversation

KooShnoo
Copy link
Contributor

@KooShnoo KooShnoo commented Oct 30, 2024

Adds MapdataCheckPoint and MapdataCheckPath, but not the rest of the checkpoint infrastructure like all the sector functions.

This is the first PR towards syncing respawn positions, verifying lap completion, and calculating lap times and finish times.

Makes progress towards #20.

source/game/system/map/MapdataCheckPoint.cc Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
@KooShnoo KooShnoo force-pushed the checkpoint branch 3 times, most recently from 635b38a to 8da456a Compare October 31, 2024 03:56
@KooShnoo KooShnoo force-pushed the checkpoint branch 2 times, most recently from 22a87c7 to 319c267 Compare October 31, 2024 05:19
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/CourseMap.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
@KooShnoo KooShnoo force-pushed the checkpoint branch 2 times, most recently from f8af5d4 to 2e65b24 Compare November 1, 2024 03:28
@vabold vabold added the P1 Priority: High label Nov 4, 2024
@vabold vabold added P2 Priority: Medium and removed P1 Priority: High labels Nov 10, 2024
Copy link
Owner

@vabold vabold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, I'll wait until the other review comments have been addressed and the rebase has happened for closer review.

source/game/system/CourseMap.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
@vabold vabold added P1 Priority: High and removed P2 Priority: Medium labels Nov 14, 2024
@KooShnoo KooShnoo force-pushed the checkpoint branch 2 times, most recently from 690c12b to ab22ce0 Compare November 14, 2024 04:35
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
@KooShnoo KooShnoo force-pushed the checkpoint branch 3 times, most recently from fe093eb to a2db4ca Compare November 14, 2024 16:06
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
@KooShnoo KooShnoo force-pushed the checkpoint branch 3 times, most recently from ecdf044 to 7487442 Compare November 19, 2024 19:57
source/game/system/map/MapdataCheckPath.hh Show resolved Hide resolved
source/game/system/map/MapdataCheckPath.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/egg/math/Vector.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPath.cc Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPath.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPath.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.hh Outdated Show resolved Hide resolved
source/game/system/map/MapdataCheckPoint.cc Outdated Show resolved Hide resolved
source/egg/math/Vector.hh Outdated Show resolved Hide resolved
@vabold vabold merged commit a01462e into vabold:main Nov 21, 2024
4 checks passed
@KooShnoo KooShnoo deleted the checkpoint branch November 22, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants