-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Checkpoints #167
Merged
Merged
Add Checkpoints #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KooShnoo
commented
Oct 30, 2024
malleoz
suggested changes
Oct 31, 2024
KooShnoo
force-pushed
the
checkpoint
branch
3 times, most recently
from
October 31, 2024 03:56
635b38a
to
8da456a
Compare
malleoz
reviewed
Oct 31, 2024
KooShnoo
force-pushed
the
checkpoint
branch
2 times, most recently
from
October 31, 2024 05:19
22a87c7
to
319c267
Compare
malleoz
suggested changes
Nov 1, 2024
KooShnoo
force-pushed
the
checkpoint
branch
2 times, most recently
from
November 1, 2024 03:28
f8af5d4
to
2e65b24
Compare
vabold
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, I'll wait until the other review comments have been addressed and the rebase has happened for closer review.
KooShnoo
force-pushed
the
checkpoint
branch
2 times, most recently
from
November 14, 2024 04:35
690c12b
to
ab22ce0
Compare
malleoz
suggested changes
Nov 14, 2024
KooShnoo
force-pushed
the
checkpoint
branch
3 times, most recently
from
November 14, 2024 16:06
fe093eb
to
a2db4ca
Compare
malleoz
suggested changes
Nov 19, 2024
KooShnoo
force-pushed
the
checkpoint
branch
3 times, most recently
from
November 19, 2024 19:57
ecdf044
to
7487442
Compare
malleoz
suggested changes
Nov 20, 2024
vabold
requested changes
Nov 20, 2024
vabold
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
MapdataCheckPoint
andMapdataCheckPath
, but not the rest of the checkpoint infrastructure like all the sector functions.This is the first PR towards syncing respawn positions, verifying lap completion, and calculating lap times and finish times.
Makes progress towards #20.