Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final keyword where applicable #108

Open
malleoz opened this issue Jun 4, 2024 · 0 comments
Open

Add final keyword where applicable #108

malleoz opened this issue Jun 4, 2024 · 0 comments
Labels
engine Code involving engine (C++) P4 Priority: Trivial quality Code quality improvements

Comments

@malleoz
Copy link
Contributor

malleoz commented Jun 4, 2024

In the interest of continued improvements that prevent us from shooting ourselves in the foot, we should add the final keyword to derived classes which should not be inherited from. Examples:

  • KartDynamicsBike
  • KartTireRearBike
@vabold vabold added engine Code involving engine (C++) improvement Improvement to existing code P4 Priority: Trivial labels Jul 11, 2024
@vabold vabold added quality Code quality improvements and removed improvement Improvement to existing code labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine Code involving engine (C++) P4 Priority: Trivial quality Code quality improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malleoz @vabold