Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SlotTargetMixin for checkbox and radio-button #2482

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Sep 8, 2021

Description

This PR introduces SlotTargetMixin that forwards every node from a source slot to a target element.

The SlotTargetMixin is based on the prototype.

The SlotTargetMixin is needed by the future SlotLabelMixin to move the content from the default slot (a conventional way to define a label for a checkbox) to the slotted <label> element.

Part of #2211

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen force-pushed the feat/slot-target-mixin branch from 96da548 to 40ee012 Compare September 8, 2021 14:14
@vursen vursen force-pushed the feat/slot-target-mixin branch from 40ee012 to cf67ae1 Compare September 9, 2021 06:34
@vursen vursen changed the title feat: add SlotTargetMixin for checkbox and radio-button (WIP) feat: add SlotTargetMixin for checkbox and radio-button Sep 9, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen requested a review from web-padawan September 9, 2021 07:30
@vursen vursen marked this pull request as ready for review September 9, 2021 07:30
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha4 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants