Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the invalid indicating background on hover #2094

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

fhdhsni
Copy link

@fhdhsni fhdhsni commented Jun 7, 2021

Description

Fixes #1149

When you hover over an invalid vaadin-text-area it should keep the background as is.
Fixes the problem by excluding [invalid] state when applying :hover styles.

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@fhdhsni fhdhsni requested a review from sissbruecker June 7, 2021 13:47
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker sissbruecker changed the title fix(vaadin-text-field): keep the invalid indicating background on hover fix: keep the invalid indicating background on hover Jun 7, 2021
@sissbruecker sissbruecker merged commit 5f50d14 into master Jun 7, 2021
@sissbruecker sissbruecker deleted the fix/text-area-invalid-background branch June 7, 2021 14:24
sissbruecker added a commit to vaadin/vaadin-text-field that referenced this pull request Oct 19, 2021
sissbruecker added a commit to vaadin/vaadin-text-field that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[text-field] Incorrect appearance of invalid text-area on hover
2 participants