Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox] Regression: the checkbox is not clickable over the whole area #2693

Closed
vursen opened this issue Sep 30, 2021 · 0 comments · Fixed by #2739
Closed

[checkbox] Regression: the checkbox is not clickable over the whole area #2693

vursen opened this issue Sep 30, 2021 · 0 comments · Fixed by #2739
Assignees
Labels
a11y Accessibility issue regression Sometimes we make things break

Comments

@vursen
Copy link
Contributor

vursen commented Sep 30, 2021

Description

Since we've changed the checkbox such that it relies on the native input change event rather than the click event on the component (#2539), now it can be switched only by click on the label or input while before it was clickable over the whole area.

Expected outcome

The whole area is clickable.

Actual outcome

Click on the corners does not trigger change.

Live Demo (optional)

Screen.Recording.2021-09-30.at.16.45.44.mov

Minimal reproducible example

<vaadin-checkbox value="economy">Economy</vaadin-checkbox>

Steps to reproduce

  1. Run yarn debug --group checkbox.
  2. Open https://localhost:8000/dev/checkbox.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue regression Sometimes we make things break
Projects
None yet
1 participant