Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button base class using new mixins #2223

Closed
web-padawan opened this issue Jul 8, 2021 · 0 comments · Fixed by #2354
Closed

Add button base class using new mixins #2223

web-padawan opened this issue Jul 8, 2021 · 0 comments · Fixed by #2354
Assignees
@vursen
Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-button

Comments

@web-padawan
Copy link
Member

web-padawan commented Jul 8, 2021 •
edited
Loading

Motivation

This is a first part of updating vaadin-button to use new DOM structure.

Depends on #2186
Depends on #2210 (needs ActiveMixin)

Proposed solution

  1. Create @vaadin/button package.
  2. Add a class without defining a custom element - prototype
  3. Copy vaadin-button test suite, excluding tests covered by @vaadin/field-base mixins tests.

Related a11y issues

See #153 (button is listed among other components), #600, #866.
@web-padawan web-padawan added a11y Accessibility issue vaadin-button a11y phase 1 First batch of accessibility fixes labels Jul 8, 2021
@web-padawan web-padawan mentioned this issue Jul 8, 2021
Closed
@vursen vursen self-assigned this Aug 17, 2021
@vursen vursen mentioned this issue Aug 18, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vursen vursen

Labels
a11y phase 1 First batch of accessibility fixes a11y Accessibility issue vaadin-button
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add new button package vaadin/web-components
2 participants
@vursen @web-padawan