Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS linting to import root level interfaces #181

Closed
web-padawan opened this issue Mar 25, 2021 · 0 comments · Fixed by #2958
Closed

Update TS linting to import root level interfaces #181

web-padawan opened this issue Mar 25, 2021 · 0 comments · Fixed by #2958
Assignees
Labels
internal typescript TypeScript definitions issue

Comments

@web-padawan
Copy link
Member

We had some files incorrectly referencing each other which caused errors like this:

      "node_modules/@vaadin/vaadin-app-layout/vaadin-app-layout.d.ts(2,15): error TS2307: Cannot find module './@types/interfaces' or its corresponding type declarations.\n",

This should never happen again, as we have TS in place.

Action point: update packages/**/test/typings to import from the root level entrypoints, not from src.

@web-padawan web-padawan self-assigned this Mar 25, 2021
@web-padawan web-padawan added the typescript TypeScript definitions issue label Apr 12, 2021
@web-padawan web-padawan changed the title Update TS linting to unclude root level interfaces Update TS linting to import root level interfaces Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal typescript TypeScript definitions issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant