Skip to content

Commit

Permalink
fix: add missing type definitions for all-imports.js (#4875) (#4891)
Browse files Browse the repository at this point in the history
  • Loading branch information
web-padawan authored Nov 2, 2022
1 parent f0a522c commit 4b3990b
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 8 deletions.
10 changes: 10 additions & 0 deletions packages/grid/all-imports.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export * from './vaadin-grid-column-group.js';
export * from './vaadin-grid-column.js';
export * from './vaadin-grid-filter.js';
export * from './vaadin-grid-filter-column.js';
export * from './vaadin-grid-selection-column.js';
export * from './vaadin-grid-sorter.js';
export * from './vaadin-grid-sort-column.js';
export * from './vaadin-grid-tree-column.js';
export * from './vaadin-grid-tree-toggle.js';
export * from './vaadin-grid.js';
11 changes: 11 additions & 0 deletions packages/grid/all-imports.js
Original file line number Diff line number Diff line change
@@ -1 +1,12 @@
import './theme/lumo/all-imports.js';

export * from './vaadin-grid-column-group.js';
export * from './vaadin-grid-column.js';
export * from './vaadin-grid-filter.js';
export * from './vaadin-grid-filter-column.js';
export * from './vaadin-grid-selection-column.js';
export * from './vaadin-grid-sorter.js';
export * from './vaadin-grid-sort-column.js';
export * from './vaadin-grid-tree-column.js';
export * from './vaadin-grid-tree-toggle.js';
export * from './vaadin-grid.js';
1 change: 1 addition & 0 deletions packages/grid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"main": "vaadin-grid.js",
"module": "vaadin-grid.js",
"files": [
"all-imports.d.ts",
"all-imports.js",
"src",
"theme",
Expand Down
23 changes: 15 additions & 8 deletions packages/grid/test/typings/grid.types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
import { ElementMixinClass } from '@vaadin/component-base/src/element-mixin.js';
import { ThemableMixinClass } from '@vaadin/vaadin-themable-mixin';
import {
GridColumnGroup,
GridFilter,
GridFilterColumn,
GridFilterValueChangedEvent,
GridSelectionColumn,
GridSelectionColumnSelectAllChangedEvent,
GridSortColumn,
GridSortColumnDirectionChangedEvent,
GridSorter,
GridSorterDirectionChangedEvent,
GridTreeColumn,
GridTreeToggle,
GridTreeToggleExpandedChangedEvent,
} from '../../all-imports.js';
import { ActiveItemMixinClass } from '../../src/vaadin-grid-active-item-mixin';
import { ArrayDataProviderMixinClass } from '../../src/vaadin-grid-array-data-provider-mixin';
import { ColumnReorderingMixinClass } from '../../src/vaadin-grid-column-reordering-mixin';
Expand Down Expand Up @@ -39,14 +54,6 @@ import {
GridSorterDefinition,
GridSorterDirection,
} from '../../vaadin-grid.js';
import { GridColumnGroup } from '../../vaadin-grid-column-group';
import { GridFilter, GridFilterValueChangedEvent } from '../../vaadin-grid-filter.js';
import { GridFilterColumn } from '../../vaadin-grid-filter-column';
import { GridSelectionColumn, GridSelectionColumnSelectAllChangedEvent } from '../../vaadin-grid-selection-column.js';
import { GridSortColumn, GridSortColumnDirectionChangedEvent } from '../../vaadin-grid-sort-column.js';
import { GridSorter, GridSorterDirectionChangedEvent } from '../../vaadin-grid-sorter.js';
import { GridTreeColumn } from '../../vaadin-grid-tree-column';
import { GridTreeToggle, GridTreeToggleExpandedChangedEvent } from '../../vaadin-grid-tree-toggle.js';

interface TestGridItem {
testProperty: string;
Expand Down

0 comments on commit 4b3990b

Please sign in to comment.