Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[time-picker] VoiceOver announces label and suffix's aria-label with each value change #540

Closed
anezthes opened this issue Apr 23, 2020 · 2 comments
Labels
a11y Accessibility issue bug Something isn't working Severity: Minor vaadin-time-picker

Comments

@anezthes
Copy link
Contributor

Tested https://cdn.vaadin.com/vaadin-time-picker/2.1.0-alpha2/demo/#time-picker-basic-demos with VoiceOver on Chrome and Safari.

Focus the first vaadin-time-picker and tab through the values with the Arrow Up and Arrow Down keys. each value change, VoiceOver will announce:

01:00 Arrival hour (hh:mm) Time selector
02:00 Arrival hour (hh:mm) Time selector
...

Formula: <value> <label> <bullet>* <aria-label>.
*Only on Safari.

Compare that to the "Step" vaadin-combo-box in the same demo which only announces the value which IMO is the expected result.

@web-padawan
Copy link
Member

Note that label is also announced twice and the second one is most likely because of role="application"
https://github.com/vaadin/vaadin-time-picker/blob/2aeeedda451c9a39005e341689f82ef1d45ec839/src/vaadin-time-picker.html#L59

Screenshot 2020-10-06 at 11 22 03

@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-time-picker May 19, 2021
@vaadin-bot vaadin-bot added a11y Accessibility issue bug Something isn't working Severity: Minor vaadin-time-picker labels May 19, 2021
@web-padawan web-padawan changed the title VoiceOver announces label and suffix's aria-label with each value change [time-picker] VoiceOver announces label and suffix's aria-label with each value change May 28, 2021
@web-padawan web-padawan self-assigned this Sep 19, 2021
@web-padawan web-padawan removed their assignment Jan 3, 2022
@web-padawan
Copy link
Member

We have removed role="application" in #2201 and addressed many other a11y issues in Vaadin 22. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue bug Something isn't working Severity: Minor vaadin-time-picker
Projects
None yet
Development

No branches or pull requests

3 participants