Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position the material text-area bottom bar (CP) #589

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

tomivirkki
Copy link
Member

Backport vaadin/web-components#3359 for Vaadin 14

@tomivirkki tomivirkki merged commit b6c8bb3 into master Feb 2, 2022
@tomivirkki tomivirkki deleted the fix-material-text-area-bar-position-cp branch February 2, 2022 11:54
@StainlessSteelRat
Copy link

This seems to break wheel scrolling a container which has a text-area inside it. If the mouse pointer is over the text-area, then the container won't scroll. I guess this is because the textarea is consuming the scroll event. (If the mouse pointer is over anywhere else on the container or other componet in the container, then scrolling works fine.)

@tomivirkki
Copy link
Member Author

Hi @StainlessSteelRat, yeah it's the e.preventDefault() in the new "wheel" event listener that causes it. We should change it so that the event gets canceled only if the text area's scroll position changes. Please report as a new issue in https://github.com/vaadin/web-components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants