Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Polymer 3 #131

Closed
web-padawan opened this issue Jun 6, 2019 · 4 comments · Fixed by #163
Closed

Convert to Polymer 3 #131

web-padawan opened this issue Jun 6, 2019 · 4 comments · Fixed by #163
Assignees
@web-padawan
Labels
typescript TypeScript definitions issue

Comments

@web-padawan
Copy link
Member

web-padawan commented Jun 6, 2019 •
edited
Loading

No description provided.

@web-padawan web-padawan self-assigned this Jun 6, 2019
@web-padawan web-padawan added the next LitElement based version issue label Jun 6, 2019
@abdonrd
Copy link
Contributor

abdonrd commented May 26, 2020

There are news here?

@web-padawan
Copy link
Member Author

Not really. This component is planned to be done as part of the bigger batch targeting Vaadin 18 (to be release in December). Those are our preliminary plans, nothing is set in stone yet.

Converting the component itself is a small effort but we need to figure out if the suggested fixes for a11y issues, namely #96 and #144 are working properly. Also we might want to look at #73

@abdonrd
Copy link
Contributor

abdonrd commented Jun 2, 2020 •
edited
Loading

Ok, thanks @web-padawan! We are starting a new project with LitElement and we wanted to use the Vaadin Button component (also Vaadin App Layout & Vaadin Tabs), but not if we have to rely on Polymer Library.

@web-padawan web-padawan changed the title LitElement + ES modules conversion Convert to Polymer 3 Dec 2, 2020
@web-padawan web-padawan added typescript TypeScript definitions issue and removed next LitElement based version issue labels Dec 2, 2020
@web-padawan
Copy link
Member Author

Update: we are going to convert to Polymer 3 first, and update tests. This should make further conversion easier.

@web-padawan web-padawan removed their assignment Dec 7, 2020
@web-padawan web-padawan self-assigned this Jan 18, 2021
@web-padawan web-padawan mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@web-padawan web-padawan

Labels
typescript TypeScript definitions issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert to Polymer 3 vaadin/vaadin-button
2 participants
@abdonrd @web-padawan