Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DevelopmentServerLaunder & WebDriverManager for integration tests #1821

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Sep 6, 2024

Also update the IT tests to use new deployment paths, convert to using
direct imports to Assert methods, and switch to catching
ElementNotInteractableException for added compatibility
(ElementNotVisibleException extends it).

@Ansku Ansku marked this pull request as draft September 6, 2024 23:35
@Ansku Ansku force-pushed the updateIT20240906v8 branch 4 times, most recently from 46253db to 1a05ccd Compare September 9, 2024 18:02
@Ansku Ansku changed the title chore: DevelopmentServelLaunder for integration test module chore: DevelopmentServelLaunder & WebDriverManager for integration tests Sep 9, 2024
@Ansku Ansku marked this pull request as ready for review September 9, 2024 18:13
Also update the IT tests to use new deployment paths, convert to using
direct imports to Assert methods, and switch to catching
ElementNotInteractableException for added compatibility
(ElementNotVisibleException extends it).
@Ansku Ansku changed the title chore: DevelopmentServelLaunder & WebDriverManager for integration tests chore: DevelopmentServerLaunder & WebDriverManager for integration tests Sep 9, 2024
Copy link
Contributor

@thevaadinman thevaadinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't detect anything inherently dangerous in here, though the dependency list could probably do with some pruning. Regardless, approved.

@Ansku Ansku merged commit a6e8618 into 5.3 Sep 11, 2024
2 checks passed
@Ansku Ansku deleted the updateIT20240906v8 branch September 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants