Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

totalTimeSpentRendering and totalTimeSpentServicingRequests fail #1704

Closed
javier-godoy opened this issue Dec 7, 2023 · 1 comment · Fixed by #1715
Closed

totalTimeSpentRendering and totalTimeSpentServicingRequests fail #1704

javier-godoy opened this issue Dec 7, 2023 · 1 comment · Fixed by #1715
Assignees
Labels

Comments

@javier-godoy
Copy link

Neither totalTimeSpentRendering nor totalTimeSpentServicingRequests considers Flow.clients.TypeScript (see vaadin/flow#7514).

In consequence, totalTimeSpentRendering fails with:

org.openqa.selenium.JavascriptException: javascript error: Performance data is not available in production mode 

and totalTimeSpentServicingRequests fails with:

window.Vaadin.Flow.clients[client].poll is not a function

Vaadin 24.2.5

@mshabarov
Copy link
Contributor

Apparently getProfilingData() and poll() functions aren't implemented for TypeScript client.
Until these two are implemented in (Hilla ?), we might need to check if poll() function is defined before calling it, and check if the client is of type "TypeScript" before checking it. This at least would fix the API for Hilla applications.

@mshabarov mshabarov added the bug label Dec 19, 2023
@mshabarov mshabarov moved this to 🔖 Normal Priority (P2) in Vaadin Flow bugs & maintenance (Vaadin 10+) Dec 19, 2023
@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Dec 19, 2023
@mshabarov mshabarov moved this from 🪵Product backlog to 🟢Ready to Go in Vaadin Flow ongoing work (Vaadin 10+) Dec 19, 2023
@tepi tepi self-assigned this Dec 19, 2023
@tepi tepi moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Dec 19, 2023
@github-project-automation github-project-automation bot moved this from ⚒️ In progress to Done in Vaadin Flow ongoing work (Vaadin 10+) Dec 20, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Normal Priority (P2) to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants