Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR request: Variable hub port #1657

Closed
ErrorProne opened this issue Aug 3, 2023 · 0 comments · Fixed by #1675
Closed

PR request: Variable hub port #1657

ErrorProne opened this issue Aug 3, 2023 · 0 comments · Fixed by #1675

Comments

@ErrorProne
Copy link

ErrorProne commented Aug 3, 2023

I've a small change to make the selenium hub port variable for which I would like to open a pull request main...ErrorProne:testbench:variableHubPort

Right now one is forced to the default 4444 port. This can be problematic in some cases, for example in shared docker environments in CI pipelines, and could lead to conflicting port mappings. It is also discouraged by libs like testcontainers which actively try to avoid mapping fixed ports to the docker host (still possible to do tho).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants