Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LitElement support 1.0 for Java developers #1524

Closed
11 tasks done
mstahv opened this issue Sep 15, 2020 · 3 comments
Closed
11 tasks done

LitElement support 1.0 for Java developers #1524

mstahv opened this issue Sep 15, 2020 · 3 comments
Labels
acceptance criteria used for the acceptance criteria checklist v18

Comments

@mstahv
Copy link
Member

mstahv commented Sep 15, 2020

As a Vaadin developer using Java for UIs, I want to be able to define my view as a LitElement template and connect UI logic to it using pure Java and only Java.

Acceptance criteria

  • When creating declarative layouts (templates), things are based on Lit (instead of current Polymer)
  • When the template state is customized (via designer or by hand), the state should be 1-1 to the mapped Java component instances (AKA attributes are read by Flow)
  • It is possible to use either TS or JS as the template format, however TS is used in documentation

General criteria

  • Any relevant parts in the products are updated like the component add-on starter
    • Excluding Bakery
  • Any template examples should be TS, not JS
  • Usage of PolymerTemplate is discouraged (in code & docs) by deprecating things
  • Special cases are taken care of when reading templates:
    • global html attributes & theme are read as attributes, everything else is a property
    • it is not possible to drive data or define grid columns (or similar) via the template - this is considered to be Java logic
  • Related existing DX issues are fixed
    • toggling visibility from server side does not work without workaround
    • setting text to any element/component does not work

Details

@mstahv mstahv added the acceptance criteria used for the acceptance criteria checklist label Sep 15, 2020
@mstahv mstahv changed the title AC: LitElement support 1.0 LitElement support 1.0 for Java developers Sep 15, 2020
@knoobie
Copy link
Contributor

knoobie commented Sep 19, 2020

Do you plan to integrate I18NProvider in some way as well? Would love to customize my templates with properties / different languages. Like some kind of "custom" i18n implementation on top of lit?

That would allow for easier templating like with the ancient and lovely CustomLayout where it was possible to overwrite the HTML-content and replace some variables with translations before Vaadin adds all components to the data-location.

@pleku
Copy link
Contributor

pleku commented Sep 22, 2020

@knoobie that would be a good idea and there is a ticket about it, but not sure when it would be a part of the roadmap vaadin/flow#3906
We'll need to discuss this internally.

@knoobie
Copy link
Contributor

knoobie commented Sep 22, 2020

@pleku thanks! 👍

@ZheSun88 ZheSun88 added the v18 label Nov 18, 2020
@mstahv mstahv closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance criteria used for the acceptance criteria checklist v18
Projects
None yet
Development

No branches or pull requests

4 participants