fix(push): track onClose Atmosphere events to properly reconnect and resubscribe
#2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cromoteca
changed the title
onClose Atmosphere events to properly reconnect and resubscribe
cromoteca
force-pushed
the
fix/2834/Flux-connection-is-not-properly-resumed-in-some-cases
branch
from
578e914
to
73bdf64
Compare
…umed-in-some-cases
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
+ Coverage 92.58% 92.66% +0.07%
==========================================
Files 83 83
Lines 2807 2809 +2
Branches 724 724
==========================================
+ Hits 2599 2603 +4
+ Misses 156 155 -1
+ Partials 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new status to track if the channel was closed and trigger reconnection callback only once, but on different events, as the event chain is different according to how the connection disruption happens.
Detected chains are:
Fixes #2834
It's better to fix #2841 before merging.