Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converter JavaDoc/signature confusion #6571

Closed
heruan opened this issue Sep 28, 2019 · 1 comment · Fixed by #6613
Closed

Converter JavaDoc/signature confusion #6571

heruan opened this issue Sep 28, 2019 · 1 comment · Fixed by #6613
Labels
bug documentation
Milestone
2.1.0.beta3

Comments

@heruan
Copy link
Member

heruan commented Sep 28, 2019

Every time I write a Converter I get much in confusion:

  1. the JavaDoc on method convertToModel states:

Converts the given value from model type to presentation type.

  1. the JavaDoc on method convertToPresentation states:

Converts the given value from presentation type to model type.

Should I trust the method name or the JavaDoc? 🤔
@ujoni
Copy link
Contributor

ujoni commented Sep 30, 2019

The method names (and their return types) are correct. Thanks for the report!

@ujoni ujoni mentioned this issue Oct 3, 2019
Merged
@joheriks joheriks added this to the 2.1.0.beta2 milestone Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
2.1.0.beta3
Development

Successfully merging a pull request may close this issue.

Correct Javadoc lines vaadin/flow
3 participants
@heruan @joheriks @ujoni