Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review component demos for incorrect usage of Label #4394

Closed
marcushellberg opened this issue Jul 12, 2018 · 0 comments
Closed

Review component demos for incorrect usage of Label #4394

marcushellberg opened this issue Jul 12, 2018 · 0 comments
Labels
demo

Comments

@marcushellberg
Copy link
Member

There are still places in our component demos where Label is being used incorrectly as a text element, for instance: https://vaadin.com/components/vaadin-combo-box/java-examples/using-components

Please review all the component demos and fix any incorrect uses of Label so we don't instruct developers to use it wrong.

Related to: #3532, #4384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcushellberg @pleku @pekam