Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that web resources handled by the Vaadin Servlet are available in OSGi #4229

Closed
denis-anisimov opened this issue Jun 5, 2018 · 4 comments
Assignees
Milestone

Comments

@denis-anisimov
Copy link
Contributor

This ticket is about resources which are internally handled by the Vaadin servlet as a static resource (via StaticFileServer).
There are some internal URLs which are handled by Flow like StreamResource (their URI starts with VAADIN/dynamic/resource/) see StreamRequestHandler::generateURI .
Also VaadinServlet has logic which handles webjar URLs.
Those resources should be available as web resources in OSGi.

See mmerruko/framework@687a900 for related (but not necessary the same) support in FW8.

This will require some OSGi test environment. So it might be that this should not be done before #4227.

@denis-anisimov
Copy link
Contributor Author

This is kind of blocked by the #4227 but it doesn't have to wait when the task will be completely done (and merged).
The #4227 should give a way to check whether an application can be used in OSGi.
At least there should be a simple way to deploy an application and check the result.
Otherwise this needs to be done every time when any OSGi related task is done and this is waste of time to reinvent the testing path every time.

@denis-anisimov
Copy link
Contributor Author

denis-anisimov commented Jun 5, 2018

What needs to be done: create an application, deploy it to OSGi and make sure the internal web resources are available there (webjars and internal URLs are handled properly).
If the custom way to do this is too complicated or may be improved then provide a way which can be used to simplify this in OSGi environment (see mentioned commit in FW).

@denis-anisimov
Copy link
Contributor Author

Similar issue is #4230

@pleku pleku added this to the 1.1 milestone Jun 11, 2018
@denis-anisimov denis-anisimov self-assigned this Jul 20, 2018
@denis-anisimov
Copy link
Contributor Author

The resolution comments for this ticket:

So in the result: this issue is divided to a number of sub-issues already reported.
The only remaining part here is dedicated test for dynamic resources.

@pleku pleku modified the milestones: 1.1, 1.1.0 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants