Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with fix for #12354 #12887

Closed
mlopezFC opened this issue Jan 28, 2022 · 0 comments · Fixed by #12916
Closed

Problem with fix for #12354 #12887

mlopezFC opened this issue Jan 28, 2022 · 0 comments · Fixed by #12916
Assignees
Labels
BFP Bugfix priority, also known as Warranty bug Impact: High Severity: Major

Comments

@mlopezFC
Copy link
Collaborator

Description of the bug

This is a problem related to the fix of this issue.
That fix only solved the problem for the plus sign "+" but there are similar issues with some other characters as "%".
Is it possible to avoid the double decoding for preventing a similar issue with other characters?

Expected behavior

All of the double decoding related issues should be solved with the fix for the related issue

Minimal reproducible example

In this case with the "%" character, it's encoded as "%25" in the query parameter, but the double decoding in the Location constructor leads to an exception. As an example:
Location l = new Location("https://example.com?param=%25HF")
After decoding once, "%25HF" becomes "%HF". Since "%HF" is not a valid url-encoded pattern, it throws an exception.

Versions

  • Vaadin / Flow version: 14.8.0 (but probably also remains in the latest version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFP Bugfix priority, also known as Warranty bug Impact: High Severity: Major
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants