From adebce2a02b39c3b3870ccbdfb59e7361a97e7f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pekka=20Hyv=C3=B6nen?= Date: Wed, 25 Nov 2020 10:29:42 +0200 Subject: [PATCH] Stop logging error when updating dev dependencies (#9476) As there is a conflict with the dependencies and prevent adding the flow-dev-dependencies package to the platform (#9345), this will hide the unavoidable error that was logged for Vaadin apps. Fixes #9251 --- .../com/vaadin/flow/server/frontend/TaskRunNpmInstall.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunNpmInstall.java b/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunNpmInstall.java index 02b154a76ae..8711a82d2e4 100644 --- a/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunNpmInstall.java +++ b/flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunNpmInstall.java @@ -230,7 +230,8 @@ private JsonObject getVersions(InputStream platformVersions) String genDevDependenciesPath = getDevDependenciesFilePath(); if (genDevDependenciesPath == null) { - packageUpdater.log().error( + // #9345 - locking dev dependencies doesn't work for now + packageUpdater.log().debug( "Couldn't find dev dependencies file path from proeprties file. " + "Dev dependencies won't be locked"); return versionsJson; @@ -255,7 +256,8 @@ private JsonObject readGeneratedDevDependencies(String path) throws IOException { URL resource = classFinder.getResource(path); if (resource == null) { - packageUpdater.log().warn("Couldn't find dev dependencies file. " + // #9345 - locking dev dependencies doesn't work for now + packageUpdater.log().debug("Couldn't find dev dependencies file. " + "Dev dependencies won't be locked"); return null; }