From 8012c43ef5d1b047f96fb259d87f8d65d63c6c91 Mon Sep 17 00:00:00 2001 From: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> Date: Tue, 30 Mar 2021 15:43:44 +0300 Subject: [PATCH] chore: disable DialogShortcutIT flaky tests (#10496) Temporary solution for #10481 #10487 #10491 --- .../test/java/com/vaadin/flow/uitest/ui/DialogShortcutIT.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/DialogShortcutIT.java b/flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/DialogShortcutIT.java index 0e814423262..e5c93c70e18 100644 --- a/flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/DialogShortcutIT.java +++ b/flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/DialogShortcutIT.java @@ -9,6 +9,7 @@ import com.vaadin.testbench.TestBenchElement; import org.junit.Assert; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.openqa.selenium.By; import org.openqa.selenium.WebElement; @@ -75,6 +76,7 @@ public void dialogOpenedWithShortcutNoListenOn_sameShortcutListeningOnUi_bothExe validateLatestShortcutEvent(4, DialogShortcutView.UI_BUTTON); } + @Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10481") @Test public void dialogOpenedWithListenOnShortcut_dialogReopened_oldShortcutStillWorks() { openReusedDialog(); @@ -103,6 +105,7 @@ public void dialogOpenedWithListenOnShortcut_dialogReopened_oldShortcutStillWork validateLatestDialogShortcut(4, REUSABLE_DIALOG_ID); } + @Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10487") // vaadin/vaadin-dialog#229 @Test public void twoDialogsOpenedWithSameShortcutKeyOnListenOn_dialogWithFocusExecuted() { @@ -124,6 +127,7 @@ public void twoDialogsOpenedWithSameShortcutKeyOnListenOn_dialogWithFocusExecute validateLatestShortcutEvent(3, DialogShortcutView.UI_BUTTON); } + @Ignore("Flaky test, see https://github.com/vaadin/flow/issues/10491") // #10362 @Test public void shortcutAddedWithPreventDefault_inputFocused_enteringOtherKeysToInputWorks() {