feat: add position API to Dialog #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Nov 4, 2024
...integration-tests/src/test/java/com/vaadin/flow/component/dialog/tests/DialogTestPageIT.java
Outdated
Show resolved
Hide resolved
...og-flow-parent/vaadin-dialog-flow/src/main/java/com/vaadin/flow/component/dialog/Dialog.java
Show resolved
Hide resolved
sissbruecker
reviewed
Nov 4, 2024
...w-integration-tests/src/main/java/com/vaadin/flow/component/dialog/tests/DialogTestPage.java
Outdated
Show resolved
Hide resolved
DiegoCardoso
force-pushed
the
feat/dialog/position-api
branch
from
0f66076
to
e02d28a
Compare
sissbruecker
approved these changes
Nov 5, 2024
|
|
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the position API that uses the newly introduced
topandleftproperties added to the Dialog web component.Part of vaadin/web-components#1060
Type of change