You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the present time, the Checkbox's integration tests cover only the case when the label is set right after the checkbox's creation within a single round-trip:
However, there is another case when the user may want to change the label on an existing checkbox (that has already been sent to the client once).
This case is unfortunately not covered now that might result in undesirable passing Flow integrations tests with the new accessible <vaadin-checkbox> (see vaadin/web-components#2539). They shouldn't pass because the way the Flow Checkbox sets labels now (by overriding textContent or innerHTML) unintentionally removes the slotted <label> element that should end up throwing an exception.
The text was updated successfully, but these errors were encountered:
At the present time, the Checkbox's integration tests cover only the case when the label is set right after the checkbox's creation within a single round-trip:
The
setLabelAsHtml
method:flow-components/vaadin-checkbox-flow-parent/vaadin-checkbox-flow-integration-tests/src/main/java/com/vaadin/flow/component/checkbox/tests/CheckboxDemoPage.java
Lines 106 to 115 in 65ccf0b
The
setLabel
method:flow-components/vaadin-checkbox-flow-parent/vaadin-checkbox-flow-integration-tests/src/main/java/com/vaadin/flow/component/checkbox/tests/CheckboxDemoPage.java
Lines 37 to 45 in 65ccf0b
However, there is another case when the user may want to change the label on an existing checkbox (that has already been sent to the client once).
This case is unfortunately not covered now that might result in undesirable passing Flow integrations tests with the new accessible
<vaadin-checkbox>
(see vaadin/web-components#2539). They shouldn't pass because the way the Flow Checkbox sets labels now (by overridingtextContent
orinnerHTML
) unintentionally removes the slotted<label>
element that should end up throwing an exception.The text was updated successfully, but these errors were encountered: